Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yolov9 compatibility #1010

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added yolov9 compatibility #1010

wants to merge 6 commits into from

Conversation

Hamzalopode
Copy link
Contributor

Added Yolov9 compatibility:

  • Yolov9 model download for E & C
  • Yolov9 process ( same as yolov8 )

Other model size and demo predict will be added with time.

@fcakyon
Copy link
Collaborator

fcakyon commented Apr 8, 2024

Amazing contribution @Hamzalopode! 🚀

Please fix the errors raised in tests by:

  • Install required development packages:
pip install -e ."[dev]"
  • Reformat with black and isort:
python -m scripts.run_code_style format
  • Commit and push 💯

Hamza Ahmouny and others added 2 commits April 8, 2024 16:18
@Hamzalopode
Copy link
Contributor Author

Thanks @fcakyon !

I think everything looks good now. Let me know if there is anything else.

🚀

@fcakyon
Copy link
Collaborator

fcakyon commented Apr 8, 2024

@Hamzalopode for some reason, you updated all the prior notebook files. Can you please revert these changes?

Other than that all seems OK 🚀

@Hamzalopode
Copy link
Contributor Author

Done.

Sorry I thought that applying the styling format for the notebooks was a good idea.

@GuillaumeBruand
Copy link
Contributor

@Hamzalopode
Can we add one level of abstraction to integrate common features between yolov8 and yolov9 (see e.g. PR #988)
As far as I know there is full compatibility between the two models.

@Hamzalopode
Copy link
Contributor Author

Fixed merge conflict between the two branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants