Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With frame-pointers, exception handlers should restore RBP #687

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

gretay-js
Copy link
Contributor

Copy link
Contributor

@xclerc xclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have the equivalent change
(replacing env with ()) in the other file
("ocaml/asmcomp/amd64/emit.mlp")?

@mshinwell
Copy link
Collaborator

@gretay-js could you address Xavier's comment, then this can be merged?

@gretay-js
Copy link
Contributor Author

Shouldn't we have the equivalent change (replacing env with ()) in the other file ("ocaml/asmcomp/amd64/emit.mlp")?

We did it for some of the previous PRs ported from upstream, but I think we don't need it. I am not sure exactly how the ocaml/ directory will be updated from upstream, but if it is a rebase onto 4.14, we don't need to port individual patches, and in fact porting them might make it harder to rebase on 4.14.

@mshinwell mshinwell merged commit 1546ace into ocaml-flambda:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port #11031: With frame-pointers, exception handlers should restore RBP
4 participants