Ppxlib.0.26.0 compatibility #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks Sonja! |
This commit makes the ppx compatible with ppxlib.0.25.0.
pascutto
force-pushed
the
ppxlib.0.25.0-compatibility
branch
from
c8e3247
to
8a1c158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch PR to make the PPX compatible with ppxlib.0.26.0 which has bumped the AST to 4.14/5.00.
With this patch, the ppx just errors out when one of the new features is encountered in the AST. That's because I myself don't know all >100 ppxlib reverse dependencies well enough to decide what the behavior should be when encountering the new feature. It would be great though if you, the maintainers, could follow up on this and implement the correct behavior. For example, I'd guess that in
Opprintast,constructor_declarationshould be adapted to take into account the newvarsfield that captures explicit binders for type variables.The two new features I'm talking about are naming GADT existential (see this section in the manual or PR description here); and explicit binders for type variables (see PR description here).