Improve test robustness on OCaml 4 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
improve-test-robustuness
branch
10 times, most recently
from
ffd6ad8
to
d3386d9
Compare
polytypic
force-pushed
the
improve-test-robustuness
branch
from
d3386d9
to
2d45d03
Compare
polytypic
force-pushed
the
improve-test-robustuness
branch
from
2d45d03
to
3a73e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests seem to hang on 32-bit OCaml 4. It would seem that the problem is that on 32-bit OCaml 4 safepoints might not be added to all loops. As a workaround this PR adds additional
Domain.cpu_relax ()calls which actually translate to callingThread.yield ()on OCaml 4.