Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ephemerons immutable. #739

Merged
merged 8 commits into from
Dec 17, 2021
Merged

Make ephemerons immutable. #739

merged 8 commits into from
Dec 17, 2021

Conversation

kayceesrk
Copy link
Contributor

@kayceesrk kayceesrk commented Nov 11, 2021 •
edited

This is a port of ocaml/ocaml#10737 for multicore. Compared to ocaml/ocaml#10737 it removes all the deprecated functions.

@kayceesrk kayceesrk mentioned this pull request Nov 11, 2021
Merged
@kayceesrk
Copy link
Contributor Author

The consensus is that we keep the Bucket module in.

@kayceesrk
Add Bucket module back
d5981e8 
The module is not concurrency safe. The idea is that after 5.00 MVP,
ephemerons will be rewritten over Bucket interface.
@kayceesrk
Merge branch '5.00' into new_ephe_api
3c0522f
@kayceesrk
Copy link
Contributor Author

@ctk21 this PR should be good to go except for a quick review.

ctk21
ctk21 reviewed Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@ctk21 ctk21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a (time limited) look. The PR does not alter the underlying runtime ephemeron GC mechanisms. However I think it does remove deprecated functions and makes the OCaml interface match up with post ocaml/ocaml#10737

I spotted a minor nit: the PR still references to the removed iter, fold functions in the documentation strings in ephemeron.ml.

I did not deeply review the testsuite alterations.

@ctk21
Copy link
Collaborator

ctk21 commented Dec 13, 2021

I have further taken a look at the alterations to ephetest_par.ml. I believe the alterations are the correct ones in this case; that is I didn't spot anything where we have changed the behaviour of the test with this PR.

@kayceesrk
Copy link
Contributor Author

Thanks @ctk21. Removed mentions of iter and fold* from documentation strings.

@kayceesrk
Copy link
Contributor Author

Let me know if anything else looks odd..

@ctk21
Copy link
Collaborator

ctk21 commented Dec 17, 2021

LGTM, merging!

@ctk21 ctk21 merged commit 9e3b452 into 5.00 Dec 17, 2021
@kayceesrk kayceesrk mentioned this pull request Dec 17, 2021
Closed
damiendoligez
damiendoligez approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@damiendoligez damiendoligez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a small hiccup in ephetest_par.ml.

testsuite/tests/weak-ephe-final/ephetest_par.ml Show resolved Hide resolved
@kayceesrk kayceesrk mentioned this pull request Dec 17, 2021
Merged
sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Jan 10, 2022
@ctk21
Merge pull request ocaml-multicore/ocaml-multicore#739 from ocaml-mul…
117011e 
…ticore/new_ephe_api

Make ephemerons immutable.
ctk21 added a commit to ctk21/ocaml that referenced this pull request Jan 11, 2022
@ctk21
Merge pull request ocaml-multicore/ocaml-multicore#739 from ocaml-mul…
b18fd55 
…ticore/new_ephe_api

Make ephemerons immutable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctk21 ctk21 ctk21 left review comments

@damiendoligez damiendoligez damiendoligez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayceesrk @ctk21 @damiendoligez