Fix reachable words, part deux #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A marshaling operation can leave `extern_flags` with the `NO_SHARING` bit set. In this context, `caml_obj_reachable_words` calls `extern_init_position_table`, which does nothing, then proceeds to access the position table, causing a crash. The solution is trivial: initialize `extern_flags` before calling `extern_init_position_table`. A regression test was added. First reported at ocaml-multicore#824
avsm
force-pushed
the
fix-reachable-words-2
branch
from
1d9c179
to
daf23ef
Compare
|
synched with the 4.14 branch commit that got merged |
|
LGTM |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…reachable-words-2 Fix reachable words, part deux
ctk21
added a commit
to ctk21/ocaml
that referenced
this pull request
Jan 11, 2022
…reachable-words-2 Fix reachable words, part deux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks @xavierleroy's commits to 4.14 on ocaml/ocaml#10853, adapted for the 5.00 branch. Follow up to discussion in #828