Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OCaml 4.13 features #1680

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Jun 7, 2021

  • no regression from 4.12
  • ocaml#10013: Let-punning
  • ocaml#9584: named existentials in pattern matching
  • ocaml#10133: module type substitutions
  • no diff with test_branch.sh

@gpetiot gpetiot force-pushed the vendor-4.13-parser branch 4 times, most recently from 813f88d to f116991 Compare June 8, 2021 14:18
@gpetiot gpetiot force-pushed the vendor-4.13-parser branch 3 times, most recently from 97d9477 to 7a6bc3b Compare June 24, 2021 10:53
@gpetiot gpetiot changed the title Vendor ocaml 4.13 parser Implement OCaml 4.13 features Jun 24, 2021
@gpetiot gpetiot marked this pull request as ready for review June 24, 2021 12:05
@gpetiot gpetiot merged commit 1eea5d0 into ocaml-ppx:master Jul 6, 2021
@gpetiot gpetiot deleted the vendor-4.13-parser branch July 6, 2021 11:52
34 | sig
^^^
This 'sig' might be unmatched
Error: Syntax error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are errors printed differently ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to ocaml/ocaml#10095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants