-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OCaml 4.13 features #1680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gpetiot
commented
Jun 7, 2021
•
edited
edited
- no regression from 4.12
- ocaml#10013: Let-punning
- ocaml#9584: named existentials in pattern matching
- ocaml#10133: module type substitutions
- no diff with test_branch.sh
gpetiot
force-pushed
the
vendor-4.13-parser
branch
4 times, most recently
from
June 8, 2021 14:18
813f88d
to
f116991
Compare
gpetiot
force-pushed
the
vendor-4.13-parser
branch
3 times, most recently
from
June 24, 2021 10:53
97d9477
to
7a6bc3b
Compare
19 tasks
gpetiot
force-pushed
the
vendor-4.13-parser
branch
from
July 6, 2021 07:35
c350317
to
63c5b19
Compare
gpetiot
force-pushed
the
vendor-4.13-parser
branch
from
July 6, 2021 07:55
63c5b19
to
ccee501
Compare
hhugo
reviewed
Jul 6, 2021
34 | sig | ||
^^^ | ||
This 'sig' might be unmatched | ||
Error: Syntax error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are errors printed differently ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to ocaml/ocaml#10095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.