Attach location to constants #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
added
the
no changelog
gpetiot
commented
Jul 28, 2021
gpetiot
force-pushed
the
loc-constants
branch
from
3594d62
to
de181c7
Compare
|
I think we can assume this change won't be upstreamed so it's ready to be reviewed here. |
gpetiot
force-pushed
the
loc-constants
branch
from
fff5937
to
6754ab2
Compare
jberdine
approved these changes
Sep 3, 2021
gpetiot
force-pushed
the
loc-constants
branch
from
6754ab2
to
58ed017
Compare
|
I will wait for #1783 to be merged before merging this one |
gpetiot
force-pushed
the
loc-constants
branch
from
58ed017
to
b264a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No diff with test_branch.sh
This allows us to remove all the code that parses the tokens extracted from Source.ml to retrieve the location.
Upstream PR: ocaml/ocaml#10544