Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored parser with ocaml#10441 #1755

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Jul 30, 2021

Apply the changes of ocaml/ocaml#10441, no behavioral change

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Jul 30, 2021
@gpetiot gpetiot changed the title Update vendored parser with ocaml/10441 Update vendored parser with ocaml#10441 Jul 30, 2021
@gpetiot gpetiot merged commit bb738be into ocaml-ppx:master Jul 30, 2021
@gpetiot gpetiot deleted the update-parser-object branch July 30, 2021 11:54
@hhugo
Copy link
Collaborator

hhugo commented Jul 30, 2021

Could we commit the diff between upstream and our parser ? This would be nice to make sure we don't diverge to much

@gpetiot
Copy link
Collaborator Author

gpetiot commented Jul 30, 2021

Could we commit the diff between upstream and our parser ? This would be nice to make sure we don't diverge to much

Yes I'm opening PRs will the remaining changes, but some require to implement new things in Fmt_ast so I want to keep the PRs distinct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants