Do not use ghost locations for type constraints (ocaml#10555) #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
added
the
no changelog
Julow
reviewed
Sep 1, 2021
Comment on lines
-608
to
+619
| | Some t, Some r -> | ||
| if type_first then field_space $ fmt_type t $ fmt "@ " $ fmt_rhs r | ||
| else | ||
| | Some t, Some r -> ( | ||
| match constraint_loc with | ||
| | Some (`Constraint_lid loc) -> | ||
| field_space | ||
| $ Cmts.fmt_before c loc ~pro:(Fmt.break 1 0) ~epi:noop | ||
| $ fmt_type t $ fmt "@ " $ fmt_rhs r $ Cmts.fmt_after c loc | ||
| | Some (`Constraint_exp loc) -> | ||
| field_space $ fmt "=@;<1 2>" | ||
| $ hvbox 0 | ||
| @@ Cmts.fmt c loc | ||
| (str "(" $ cbox 0 r $ str " " $ fmt_type ~parens:true t) | ||
| | None -> |
There was a problem hiding this comment.
Because ocaml/ocaml#10555 also changed the location span used for Ppat_constraint/Pexp_constraint, so the formatting had to be updated accordingly.
Otherwise here is the diff I had:
let _ =
{ (* a *) a (* a' *)= (* b *) b (* b' *)
- ; (* c' *) (* c *) c: (* d *) d (* d' *) = (* e *) e (* e' *)
+ ; (* c' *)
+ (* c *) c: (* d *) d (* d' *) = (* e *) e
+ (* e' *)
; (* f *) f (* f' *)
; (* j *)
(* g *) g (* g' *)= ((* h *) h (* h' *) : (* i *) i (* i' *))
(* j' *) }
let { (* a *) a (* a' *)= (* b *) b (* b' *)
- ; (* c' *) (* c *) c: (* d *) d (* d' *) = (* e *) e (* e' *)
+ ; (* c' *)
+ (* c *) c: (* d *) d (* d' *) = (* e *) e
+ (* e' *)
; (* f *) f (* f' *)
; (* j *)
(* g *) g (* g' *)= ((* h *) h (* h' *) : (* i *) i (* i' *))(the previous formatting was not 100% correct by the way)
Hkoma95
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying ocaml/ocaml#10555
No diff with test_branch.sh, the changes in comments_in_record.ml are a fix.