Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings with OCaml 4.13 #22

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Remove warnings with OCaml 4.13 #22

merged 1 commit into from
Mar 18, 2021

Conversation

kit-ty-kate
Copy link
Member

In prevision of ocaml/ocaml#10207

@kit-ty-kate
Copy link
Member Author

Now that ocaml/ocaml#10207 is merged this PR is good to go.

@dra27
Copy link
Member

dra27 commented Mar 17, 2021

Please could you update the Makefiles as well?

CAMLCFLAGS=-w +a-4-9-41-42-44-45-48 -warn-error A -bin-annot -g \

and

-w +a-4-9-41-42-44-45-48 -warn-error A \

@kit-ty-kate
Copy link
Member Author

Done

@dra27
Copy link
Member

dra27 commented Mar 18, 2021

There is a question over whether -warn-error A will definitely trigger the alert, but the change is benign as things stand. I'll merge: if num 1.4 still triggers the warning when 4.13 is branched then we'll know we need to release.

@dra27 dra27 merged commit f1775d7 into ocaml:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants