Address Damien's review

ocaml · Sep 21, 2020 · 258544c · 258544c
1 parent 7290575
commit 258544c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -152,7 +152,7 @@ Working version
 ### Standard library:
 
 - #9487, #9489: Add Random.int63 which allows 62-bit bounds on 64-bit systems.
-  (David Allsopp, request by Francois Berenger, review by ??)
+  (David Allsopp, request by Francois Berenger, review by Damien Doligez)
 
 - #9865: add Format.pp_print_seq
   (Raphaël Proust, review by Nicolás Ojeda Bär)

diff --git a/stdlib/random.ml b/stdlib/random.ml
@@ -96,7 +96,7 @@ module State = struct
   let rec int63aux s n =
     let b1 = bits s in
     let b2 = bits s lsl 30 in
-    let b3 = (bits s land 3) lsl 60 in
+    let b3 = (bits s lsr 28) lsl 60 in
     let r = b1 lor b2 lor b3 in
     let v = r mod n in
     if r - v > max_int - n + 1 then int63aux s n else v