review fix

ocaml · Oct 27, 2021 · 26ec95d · 26ec95d
1 parent 23bbcca
commit 26ec95d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -49,7 +49,7 @@ Working version
   (Vincent Laviron, review by Gabriel Scherer)
 
 - #10728: Ensure that functions are evaluated after their arguments
-  (Stephen Dolan, review by ??)
+  (Stephen Dolan, review by Mark Shinwell)
 
 ### Standard library:
 

diff --git a/middle_end/closure/closure.ml b/middle_end/closure/closure.ml
@@ -795,8 +795,6 @@ let warning_if_forced_inline ~loc ~attribute warning =
 
 let direct_apply env fundesc ufunct uargs ~loc ~attribute =
   match fundesc.fun_inline, attribute with
-  | Some(params, body), _  ->
-     bind_params env loc fundesc params uargs ufunct body
   | _, Never_inline
   | None, _ ->
      let dbg = Debuginfo.from_location loc in
@@ -827,6 +825,8 @@ let direct_apply env fundesc ufunct uargs ~loc ~attribute =
                  Udirect_apply(fundesc.fun_label, app_args @ [Uvar clos], dbg)))
          args
        end
+  | Some(params, body), _  ->
+     bind_params env loc fundesc params uargs ufunct body
 
 (* Add [Value_integer] info to the approximation of an application *)