Rename set_channel_{unbuffered => buffered}

ocaml · Jul 29, 2021 · 4bef4a1 · 4bef4a1
1 parent dbfe03c
commit 4bef4a1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/Changes b/Changes
@@ -27,7 +27,7 @@ Working version
 - #10526: add Random.bits32, Random.bits64, Random.nativebits
   (Xavier Leroy, review by Gabriel Scherer and François Bobot)
 
-- #10538: add Stdlib.set_channel_unbuffered to allow disabling
+- #10538: add Stdlib.set_channel_buffered to allow disabling
   buffering on an output channel.
   (Nicolás Ojeda Bär)
 

diff --git a/runtime/io.c b/runtime/io.c
@@ -650,14 +650,14 @@ CAMLprim value caml_ml_set_binary_mode(value vchannel, value mode)
   return Val_unit;
 }
 
-CAMLprim value caml_ml_set_channel_unbuffered(value vchannel, value mode)
+CAMLprim value caml_ml_set_channel_buffered(value vchannel, value mode)
 {
   struct channel * channel = Channel(vchannel);
   if (Bool_val(mode)) {
+    channel->flags &= ~CHANNEL_FLAG_UNBUFFERED;
+  } else {
     channel->flags |= CHANNEL_FLAG_UNBUFFERED;
     caml_flush(channel);
-  } else {
-    channel->flags &= ~CHANNEL_FLAG_UNBUFFERED;
   }
   return Val_unit;
 }

diff --git a/stdlib/stdlib.ml b/stdlib/stdlib.ml
@@ -395,8 +395,8 @@ let close_out_noerr oc =
   (try close_out_channel oc with _ -> ())
 external set_binary_mode_out : out_channel -> bool -> unit
                              = "caml_ml_set_binary_mode"
-external set_channel_unbuffered : out_channel -> bool -> unit
-  = "caml_ml_set_channel_unbuffered"
+external set_channel_buffered : out_channel -> bool -> unit
+  = "caml_ml_set_channel_buffered"
 
 (* General input functions *)
 

diff --git a/stdlib/stdlib.mli b/stdlib/stdlib.mli
@@ -1062,8 +1062,8 @@ val set_binary_mode_out : out_channel -> bool -> unit
    This function has no effect under operating systems that
    do not distinguish between text mode and binary mode. *)
 
-val set_channel_unbuffered : out_channel -> bool -> unit
-(** [set_channel_unbuffered oc true] sets the channel [oc] to
+val set_channel_buffered : out_channel -> bool -> unit
+(** [set_channel_buffered oc false] sets the channel [oc] to
     unbuffered mode: the data passed to output functions on [oc]
     will be visible as soon as they return.