Show expected and received type on directive error

Changes

@@ -32,6 +32,9 @@ Working version
   (`#use "missing_file";;`) use stderr and exit with an error.
   (Florian Angeletti, review by Gabriel Scherer)
 
+- #10524: Directive argument type error now shows expected and received type.
+  (Wiktor Kuchta, review by ?)
+
 ### Manual and documentation:
 
 - #7812, #10475: reworded the description of the behaviors of

toplevel/topcommon.ml

@@ -338,7 +338,21 @@ let try_run_directive ppf dir_name pdir_arg =
       | Directive_ident f, Some {pdira_desc = Pdir_ident lid} -> f lid; true
       | Directive_bool f, Some {pdira_desc = Pdir_bool b} -> f b; true
       | _ ->
-          fprintf ppf "Wrong type of argument for directive `%s'.@."
-            dir_name;
+          let dir_type = match d with
+          | Directive_none _   -> "no argument"
+          | Directive_string _ -> "a string"
+          | Directive_int _    -> "an int"
+          | Directive_ident _  -> "an identifier"
+          | Directive_bool _   -> "a bool"
+          in
+          let arg_type = match pdir_arg with
+          | None                              -> "no argument"
+          | Some {pdira_desc = Pdir_string _} -> "a string"
+          | Some {pdira_desc = Pdir_int _}    -> "an int"
+          | Some {pdira_desc = Pdir_ident _}  -> "an identifier"
+          | Some {pdira_desc = Pdir_bool _}   -> "a bool"
+          in
+          fprintf ppf "Directive `%s' expects %s, got %s.@."
+            dir_name dir_type arg_type;
           false
   end