added warning for missing mli interface file

ocaml · Apr 4, 2020 · 91e31ce · 91e31ce
1 parent 466ed63
commit 91e31ce
Show file tree

Hide file tree

Showing 33 changed files with 45 additions and 34 deletions.
diff --git a/Changes b/Changes
@@ -195,6 +195,9 @@ Working version
   (Nicolás Ojeda Bär, review by Alain Frisch, Gabriel Scherer and Damien
   Doligez)
 
+- #9407: added warning for missing mli interface file
+  (Anukriti Kumar, review by Florian Angeletti)
+
 ### Internal/compiler-libs changes:
 
  - #463: a new Misc.Magic_number module for user-friendly parsing

diff --git a/Makefile b/Makefile
@@ -45,8 +45,8 @@ INCLUDES=-I utils -I parsing -I typing -I bytecomp -I file_formats \
         -I asmcomp -I asmcomp/debug \
         -I driver -I toplevel
 
-COMPFLAGS=-strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48-66 \
-	  -warn-error A \
+COMPFLAGS=-strict-sequence -principal -absname \
+	  -w +a-4-9-40-41-42-44-45-48-66-68 -warn-error A \
           -bin-annot -safe-string -strict-formats $(INCLUDES)
 ifeq "$(FUNCTION_SECTIONS)" "true"
 OPTCOMPFLAGS= -function-sections

diff --git a/debugger/Makefile b/debugger/Makefile
@@ -25,7 +25,7 @@ CAMLRUN ?= $(ROOTDIR)/boot/ocamlrun
 CAMLYACC ?= $(ROOTDIR)/yacc/ocamlyacc$(EXE)
 
 CAMLC=$(BEST_OCAMLC) -g -nostdlib -I $(ROOTDIR)/stdlib
-COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48 -warn-error A \
+COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48-68 -warn-error A \
           -safe-string -strict-sequence -strict-formats
 LINKFLAGS=-linkall -I $(UNIXDIR) -I $(DYNLINKDIR)
 YACCFLAGS=

diff --git a/lex/Makefile b/lex/Makefile
@@ -25,7 +25,7 @@ CAMLYACC ?= $(ROOTDIR)/yacc/ocamlyacc
 CAMLC = $(BOOT_OCAMLC) -strict-sequence -nostdlib \
         -I $(ROOTDIR)/boot -use-prims $(ROOTDIR)/runtime/primitives
 CAMLOPT = $(CAMLRUN) $(ROOTDIR)/ocamlopt -nostdlib -I $(ROOTDIR)/stdlib
-COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48 -warn-error A \
+COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48-68 -warn-error A \
             -safe-string -strict-sequence -strict-formats -bin-annot
 LINKFLAGS =
 YACCFLAGS = -v

diff --git a/man/ocamlc.m b/man/ocamlc.m
@@ -1013,7 +1013,7 @@ compilation in any way (even if it is fatal).  If a warning is enabled,
 
 .IP
 The default setting is
-.BR \-w\ +a\-4\-6\-7\-9\-27\-29\-30\-32..42\-44\-45\-48\-50\-60\-66 .
+.BR \-w\ +a\-4\-6\-7\-9\-27\-29\-30\-32..42\-44\-45\-48\-50\-60\-66\-68 .
 Note that warnings
 .BR 5 \ and \ 10
 are not always triggered, depending on the internals of the type checker.

diff --git a/ocamldoc/Makefile b/ocamldoc/Makefile
@@ -118,7 +118,7 @@ INCLUDES_NODEP=\
 DEPINCLUDES=$(INCLUDES_DEP)
 INCLUDES=$(INCLUDES_DEP) $(INCLUDES_NODEP)
 
-COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48 -warn-error A \
+COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48-68 -warn-error A \
   -safe-string -strict-sequence -strict-formats -bin-annot -principal
 
 LINKFLAGS=$(INCLUDES) -nostdlib

diff --git a/otherlibs/dynlink/Makefile b/otherlibs/dynlink/Makefile
@@ -31,8 +31,8 @@ OCAMLC=$(BEST_OCAMLC) -g -nostdlib -I $(ROOTDIR)/stdlib
 OCAMLOPT=$(BEST_OCAMLOPT) -g -nostdlib -I $(ROOTDIR)/stdlib
 
 # COMPFLAGS should be in sync with the toplevel Makefile's COMPFLAGS.
-COMPFLAGS=-strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48-66 \
-	  -warn-error A \
+COMPFLAGS=-strict-sequence -principal -absname \
+	  -w +a-4-9-40-41-42-44-45-48-66-68 -warn-error A \
           -bin-annot -safe-string -strict-formats
 ifeq "$(FLAMBDA)" "true"
 OPTCOMPFLAGS=-O3

diff --git a/stdlib/Makefile b/stdlib/Makefile
@@ -22,7 +22,7 @@ TARGET_BINDIR ?= $(BINDIR)
 
 COMPILER=$(ROOTDIR)/ocamlc
 CAMLC=$(CAMLRUN) $(COMPILER)
-COMPFLAGS=-strict-sequence -absname -w +a-4-9-41-42-44-45-48 \
+COMPFLAGS=-strict-sequence -absname -w +a-4-9-41-42-44-45-48-68 \
           -g -warn-error A -bin-annot -nostdlib \
           -safe-string -strict-formats
 ifeq "$(FLAMBDA)" "true"

diff --git a/testsuite/tests/lib-unix/win-env/test_env.ml b/testsuite/tests/lib-unix/win-env/test_env.ml
@@ -1,6 +1,6 @@
 (* TEST
 include unix
-flags += "-strict-sequence -safe-string -w A -warn-error A"
+flags += "-strict-sequence -safe-string -w A-68 -warn-error A"
 modules = "stubs.c"
 * libwin32unix
 ** bytecode

diff --git a/testsuite/tests/typing-fstclassmod/fstclassmod.ml b/testsuite/tests/typing-fstclassmod/fstclassmod.ml
@@ -1,5 +1,5 @@
 (* TEST
-   flags = "-w A -warn-error A"
+   flags = "-w A-68 -warn-error A"
 *)
 
 (* Example of algorithm parametrized with modules *)

diff --git a/testsuite/tests/warnings/deprecated_module_assigment.ml b/testsuite/tests/warnings/deprecated_module_assigment.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * bytecode
 

diff --git a/testsuite/tests/warnings/deprecated_module_use.ml b/testsuite/tests/warnings/deprecated_module_use.ml
@@ -9,7 +9,7 @@ module = "deprecated_module.mli"
 *** ocamlc.byte
 module = "deprecated_module.ml"
 **** ocamlc.byte
-flags = "-w A"
+flags = "-w A-68"
 module = "deprecated_module_use.ml"
 ***** check-ocamlc.byte-output
 

diff --git a/testsuite/tests/warnings/w01.ml b/testsuite/tests/warnings/w01.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w03.ml b/testsuite/tests/warnings/w03.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w04.ml b/testsuite/tests/warnings/w04.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w04_failure.ml b/testsuite/tests/warnings/w04_failure.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w06.ml b/testsuite/tests/warnings/w06.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w32b.ml b/testsuite/tests/warnings/w32b.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w33.ml b/testsuite/tests/warnings/w33.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w45.ml b/testsuite/tests/warnings/w45.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w47_inline.ml b/testsuite/tests/warnings/w47_inline.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w50.ml b/testsuite/tests/warnings/w50.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w51.ml b/testsuite/tests/warnings/w51.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w51_bis.ml b/testsuite/tests/warnings/w51_bis.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w53.ml b/testsuite/tests/warnings/w53.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A-60"
+flags = "-w A-60-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w54.ml b/testsuite/tests/warnings/w54.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w55.ml b/testsuite/tests/warnings/w55.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 compile_only = "true"
 
 * setup-ocamlc.byte-build-env

diff --git a/testsuite/tests/warnings/w58.ml b/testsuite/tests/warnings/w58.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 files = "module_without_cmx.mli"
 
 * setup-ocamlc.byte-build-env

diff --git a/testsuite/tests/warnings/w59.ml b/testsuite/tests/warnings/w59.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w A"
+flags = "-w A-68"
 compile_only = "true"
 
 * setup-ocamlc.byte-build-env

diff --git a/tools/Makefile b/tools/Makefile
@@ -80,8 +80,9 @@ INCLUDES = $(addprefix -I $(ROOTDIR)/,utils parsing typing bytecomp \
                        middle_end middle_end/closure middle_end/flambda \
                        middle_end/flambda/base_types driver toplevel \
                        file_formats lambda)
-COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48 -strict-sequence -warn-error A \
- -principal -safe-string -strict-formats -bin-annot $(INCLUDES)
+COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48-68 -strict-sequence \
+ -warn-error A -principal -safe-string -strict-formats \
+ -bin-annot $(INCLUDES)
 LINKFLAGS = $(INCLUDES)
 VPATH := $(filter-out -I,$(INCLUDES))
 

diff --git a/typing/typemod.ml b/typing/typemod.ml
@@ -2663,6 +2663,8 @@ let type_implementation sourcefile outputprefix modulename initial_env ast =
           gen_annot outputprefix sourcefile annots;
           (str, coercion)
         end else begin
+          Location.prerr_warning (Location.in_file sourcefile)
+            Warnings.Interface_not_found;
           let coercion =
             Includemod.compunit initial_env ~mark:Includemod.Mark_positive
               sourcefile sg "(inferred signature)" simple_sg

diff --git a/utils/warnings.ml b/utils/warnings.ml
@@ -92,6 +92,7 @@ type t =
   | Redefining_unit of string               (* 65 *)
   | Unused_open_bang of string              (* 66 *)
   | Unused_functor_parameter of string      (* 67 *)
+  | Interface_not_found                     (* 68 *)
 ;;
 
 (* If you remove a warning, leave a hole in the numbering.  NEVER change
@@ -170,9 +171,10 @@ let number = function
   | Redefining_unit _ -> 65
   | Unused_open_bang _ -> 66
   | Unused_functor_parameter _ -> 67
+  | Interface_not_found -> 68
 ;;
 
-let last_warning_number = 67
+let last_warning_number = 68
 ;;
 
 (* Must be the max number returned by the [number] function. *)
@@ -393,7 +395,7 @@ let parse_options errflag s =
   current := {(!current) with error; active}
 
 (* If you change these, don't forget to change them in man/ocamlc.m *)
-let defaults_w = "+a-4-6-7-9-27-29-30-32..42-44-45-48-50-60-66-67";;
+let defaults_w = "+a-4-6-7-9-27-29-30-32..42-44-45-48-50-60-66-67-68";;
 let defaults_warn_error = "-a+31";;
 
 let () = parse_options false defaults_w;;
@@ -631,6 +633,8 @@ let message = function
          which shadows the existing one.\n\
          Hint: Did you mean 'type %s = unit'?" name
   | Unused_functor_parameter s -> "unused functor parameter " ^ s ^ "."
+  | Interface_not_found ->
+    "Cannot find interface file."
 ;;
 
 let nerrors = ref 0;;

diff --git a/utils/warnings.mli b/utils/warnings.mli
@@ -94,6 +94,7 @@ type t =
   | Redefining_unit of string               (* 65 *)
   | Unused_open_bang of string              (* 66 *)
   | Unused_functor_parameter of string      (* 67 *)
+  | Interface_not_found                     (* 68 *)
 ;;
 
 type alert = {kind:string; message:string; def:loc; use:loc}