diffing: add parentheses in functor (sig end)

ocaml · Dec 15, 2020 · bc2b23c · bc2b23c
1 parent 4a3d180
commit bc2b23c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/testsuite/tests/typing-modules/functors.ml b/testsuite/tests/typing-modules/functors.ml
@@ -1569,7 +1569,7 @@ Error: Signature mismatch:
          functor (Arg : $S1) (X : $S2) (Res : X.T) (Res : X.T) (Res :
          X.T) -> ...
        is not included in
-         functor sig end (X : $T2) X.T X.T -> ...
+         functor (sig end) (X : $T2) X.T X.T -> ...
        1. Module types do not match:
             $S1 = sig type wrong end
           does not include

diff --git a/typing/includemod.ml b/typing/includemod.ml
@@ -1401,6 +1401,8 @@ module Pp = struct
 
   let functor_param x = match Short_name.functor_param x with
     | Short_name.Unit -> Format.dprintf "()"
+    | Short_name.Named (None, Original (Mty_signature []) ) ->
+        Format.dprintf "(sig end)"
     | Short_name.Named (None, short_mty) ->
         Short_name.pp dmodtype short_mty
     | Short_name.Named (Some p, short_mty) ->