Merge pull request #9407 from Anukriti12/interface_not_found

added warning for missing mli interface file
ocaml · Mar 31, 2021 · f0a1be6 · f0a1be6
2 parents bef455a + fd247ba
commit f0a1be6
Show file tree

Hide file tree

Showing 34 changed files with 47 additions and 33 deletions.
diff --git a/Changes b/Changes
@@ -172,6 +172,9 @@ Working version
 
 ### Compiler user-interface and warnings:
 
+- #9407: added warning for missing mli interface file
+  (Anukriti Kumar, review by Florian Angeletti)
+
 - #9960: extend ocamlc/ocamlopt's -o option to work when compiling C files
   (Sébastien Hinderer, reported by Daniel Bünzli, review by Florian
   Angeletti and Gabriel Scherer)

diff --git a/Makefile b/Makefile
@@ -42,7 +42,8 @@ INCLUDES=-I utils -I parsing -I typing -I bytecomp -I file_formats \
         -I asmcomp -I asmcomp/debug \
         -I driver -I toplevel
 
-COMPFLAGS=-strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48-66 \
+COMPFLAGS=-strict-sequence -principal -absname \
+          -w +a-4-9-40-41-42-44-45-48-66-70 \
 	  -warn-error +a \
           -bin-annot -safe-string -strict-formats $(INCLUDES)
 LINKFLAGS=

diff --git a/debugger/Makefile b/debugger/Makefile
@@ -22,7 +22,7 @@ DYNLINKDIR=$(ROOTDIR)/otherlibs/dynlink
 UNIXDIR=$(ROOTDIR)/otherlibs/$(UNIXLIB)
 
 CAMLC=$(BEST_OCAMLC) -g -nostdlib -I $(ROOTDIR)/stdlib
-COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48 -warn-error +A \
+COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48-70 -warn-error +A \
           -safe-string -strict-sequence -strict-formats
 LINKFLAGS=-linkall -I $(UNIXDIR) -I $(DYNLINKDIR)
 OCAMLLEX ?= $(BEST_OCAMLLEX)

diff --git a/lex/Makefile b/lex/Makefile
@@ -24,7 +24,7 @@ OCAMLYACCFLAGS = -v
 CAMLC = $(BOOT_OCAMLC) -strict-sequence -nostdlib \
         -I $(ROOTDIR)/boot -use-prims $(ROOTDIR)/runtime/primitives
 CAMLOPT = $(CAMLRUN) $(ROOTDIR)/ocamlopt$(EXE) -nostdlib -I $(ROOTDIR)/stdlib
-COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48 -warn-error +A \
+COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48-70 -warn-error +A \
             -safe-string -strict-sequence -strict-formats -bin-annot
 LINKFLAGS =
 OCAMLLEX ?= $(BOOT_OCAMLLEX)

diff --git a/man/ocamlc.m b/man/ocamlc.m
@@ -1025,7 +1025,7 @@ compilation in any way (even if it is fatal).  If a warning is enabled,
 
 .IP
 The default setting is
-.BR \-w\ +a\-4\-6\-7\-9\-27\-29\-30\-32..42\-44\-45\-48\-50\-60\-66..69 .
+.BR \-w\ +a\-4\-6\-7\-9\-27\-29\-30\-32..42\-44\-45\-48\-50\-60\-66..70 .
 Note that warnings
 .BR 5 \ and \ 10
 are not always triggered, depending on the internals of the type checker.

diff --git a/ocamldoc/Makefile b/ocamldoc/Makefile
@@ -75,7 +75,7 @@ INCLUDES_NODEP=\
 DEPINCLUDES=$(INCLUDES_DEP)
 INCLUDES=$(INCLUDES_DEP) $(INCLUDES_NODEP)
 
-COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48 -warn-error +A \
+COMPFLAGS=$(INCLUDES) -absname -w +a-4-9-41-42-44-45-48-70 -warn-error +A \
   -safe-string -strict-sequence -strict-formats -bin-annot -principal
 
 LINKFLAGS=$(INCLUDES) -nostdlib

diff --git a/otherlibs/dynlink/Makefile b/otherlibs/dynlink/Makefile
@@ -28,7 +28,8 @@ OCAMLC=$(BEST_OCAMLC) -g -nostdlib -I $(ROOTDIR)/stdlib
 OCAMLOPT=$(BEST_OCAMLOPT) -g -nostdlib -I $(ROOTDIR)/stdlib
 
 # COMPFLAGS should be in sync with the toplevel Makefile's COMPFLAGS.
-COMPFLAGS=-strict-sequence -principal -absname -w +a-4-9-40-41-42-44-45-48-66 \
+COMPFLAGS=-strict-sequence -principal -absname \
+          -w +a-4-9-40-41-42-44-45-48-66-70 \
 	  -warn-error +A \
           -bin-annot -safe-string -strict-formats
 ifeq "$(FLAMBDA)" "true"

diff --git a/stdlib/Makefile b/stdlib/Makefile
@@ -21,7 +21,7 @@ TARGET_BINDIR ?= $(BINDIR)
 
 COMPILER=$(ROOTDIR)/ocamlc$(EXE)
 CAMLC=$(CAMLRUN) $(COMPILER)
-COMPFLAGS=-strict-sequence -absname -w +a-4-9-41-42-44-45-48 \
+COMPFLAGS=-strict-sequence -absname -w +a-4-9-41-42-44-45-48-70 \
           -g -warn-error +A -bin-annot -nostdlib -principal \
           -safe-string -strict-formats
 ifeq "$(FLAMBDA)" "true"

diff --git a/testsuite/tests/lib-unix/win-env/test_env.ml b/testsuite/tests/lib-unix/win-env/test_env.ml
@@ -1,6 +1,6 @@
 (* TEST
 include unix
-flags += "-strict-sequence -safe-string -w +A -warn-error +A"
+flags += "-strict-sequence -safe-string -w +A-70 -warn-error +A"
 modules = "stubs.c"
 * libwin32unix
 ** bytecode

diff --git a/testsuite/tests/typing-fstclassmod/fstclassmod.ml b/testsuite/tests/typing-fstclassmod/fstclassmod.ml
@@ -1,5 +1,5 @@
 (* TEST
-   flags = "-w +A -warn-error +A"
+   flags = "-w +A-70 -warn-error +A"
 *)
 
 (* Example of algorithm parametrized with modules *)

diff --git a/testsuite/tests/warnings/deprecated_module_assigment.ml b/testsuite/tests/warnings/deprecated_module_assigment.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * bytecode
 

diff --git a/testsuite/tests/warnings/deprecated_module_use.ml b/testsuite/tests/warnings/deprecated_module_use.ml
@@ -9,7 +9,7 @@ module = "deprecated_module.mli"
 *** ocamlc.byte
 module = "deprecated_module.ml"
 **** ocamlc.byte
-flags = "-w +A"
+flags = "-w +A-70"
 module = "deprecated_module_use.ml"
 ***** check-ocamlc.byte-output
 

diff --git a/testsuite/tests/warnings/w01.ml b/testsuite/tests/warnings/w01.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w03.ml b/testsuite/tests/warnings/w03.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w04.ml b/testsuite/tests/warnings/w04.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w04_failure.ml b/testsuite/tests/warnings/w04_failure.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w06.ml b/testsuite/tests/warnings/w06.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w32b.ml b/testsuite/tests/warnings/w32b.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w33.ml b/testsuite/tests/warnings/w33.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w45.ml b/testsuite/tests/warnings/w45.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w47_inline.ml b/testsuite/tests/warnings/w47_inline.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w50.ml b/testsuite/tests/warnings/w50.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w51.ml b/testsuite/tests/warnings/w51.ml
@@ -1,5 +1,5 @@
 (* TEST
-   flags = "-w +A"
+   flags = "-w +A-70"
    * expect
 *)
 

diff --git a/testsuite/tests/warnings/w51_bis.ml b/testsuite/tests/warnings/w51_bis.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w53.ml b/testsuite/tests/warnings/w53.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A-60"
+flags = "-w +A-60-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w54.ml b/testsuite/tests/warnings/w54.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlc.byte-build-env
 ** ocamlc.byte

diff --git a/testsuite/tests/warnings/w55.ml b/testsuite/tests/warnings/w55.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 compile_only = "true"
 
 * setup-ocamlc.byte-build-env

diff --git a/testsuite/tests/warnings/w58.ml b/testsuite/tests/warnings/w58.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 files = "module_without_cmx.mli"
 
 * setup-ocamlc.byte-build-env

diff --git a/testsuite/tests/warnings/w59.ml b/testsuite/tests/warnings/w59.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 compile_only = "true"
 
 * setup-ocamlc.byte-build-env

diff --git a/testsuite/tests/warnings/w68.ml b/testsuite/tests/warnings/w68.ml
@@ -1,6 +1,6 @@
 (* TEST
 
-flags = "-w +A"
+flags = "-w +A-70"
 
 * setup-ocamlopt.byte-build-env
 ** ocamlopt.byte

diff --git a/tools/Makefile b/tools/Makefile
@@ -76,8 +76,8 @@ INCLUDES = $(addprefix -I $(ROOTDIR)/,utils parsing typing bytecomp \
                        middle_end middle_end/closure middle_end/flambda \
                        middle_end/flambda/base_types driver toplevel \
                        file_formats lambda)
-COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48 -strict-sequence -warn-error +A \
- -principal -safe-string -strict-formats -bin-annot $(INCLUDES)
+COMPFLAGS = -absname -w +a-4-9-41-42-44-45-48-70 -strict-sequence \
+-warn-error +A -principal -safe-string -strict-formats -bin-annot $(INCLUDES)
 LINKFLAGS = $(INCLUDES)
 VPATH := $(filter-out -I,$(INCLUDES))
 

diff --git a/typing/typemod.ml b/typing/typemod.ml
@@ -2816,6 +2816,8 @@ let type_implementation sourcefile outputprefix modulename initial_env ast =
             signature = dclsig
           }
         end else begin
+          Location.prerr_warning (Location.in_file sourcefile)
+            Warnings.Missing_mli;
           let coercion =
             Includemod.compunit initial_env ~mark:Mark_positive
               sourcefile sg "(inferred signature)" simple_sg

diff --git a/utils/warnings.ml b/utils/warnings.ml
@@ -104,6 +104,7 @@ type t =
   | Unused_functor_parameter of string      (* 67 *)
   | Match_on_mutable_state_prevent_uncurry  (* 68 *)
   | Unused_field of string * field_usage_warning (* 69 *)
+  | Missing_mli                             (* 70 *)
 ;;
 
 (* If you remove a warning, leave a hole in the numbering.  NEVER change
@@ -183,9 +184,10 @@ let number = function
   | Unused_functor_parameter _ -> 67
   | Match_on_mutable_state_prevent_uncurry -> 68
   | Unused_field _ -> 69
+  | Missing_mli -> 70
 ;;
 
-let last_warning_number = 69
+let last_warning_number = 70
 ;;
 
 (* Third component of each tuple is the list of names for each warning. The
@@ -346,6 +348,8 @@ let descriptions =
     ["match-on-mutable-state-prevent-uncurry"];
     69, "Unused record field.",
     ["unused-field"];
+    70, "Missing interface file.",
+    ["missing-mli"]
   ]
 ;;
 
@@ -658,7 +662,7 @@ let parse_options errflag s =
   alerts
 
 (* If you change these, don't forget to change them in man/ocamlc.m *)
-let defaults_w = "+a-4-6-7-9-27-29-30-32..42-44-45-48-50-60-66..69";;
+let defaults_w = "+a-4-6-7-9-27-29-30-32..42-44-45-48-50-60-66..70";;
 let defaults_warn_error = "-a+31";;
 
 let () = ignore @@ parse_options false defaults_w;;
@@ -909,6 +913,8 @@ let message = function
   | Unused_field (s, Not_mutated) ->
       "mutable record field " ^ s ^
       " is never mutated."
+  | Missing_mli ->
+    "Cannot find interface file."
 ;;
 
 let nerrors = ref 0;;

diff --git a/utils/warnings.mli b/utils/warnings.mli
@@ -106,6 +106,7 @@ type t =
   | Unused_functor_parameter of string      (* 67 *)
   | Match_on_mutable_state_prevent_uncurry  (* 68 *)
   | Unused_field of string * field_usage_warning (* 69 *)
+  | Missing_mli                             (* 70 *)
 ;;
 
 type alert = {kind:string; message:string; def:loc; use:loc}