-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose module signature when typing implementation #10007
Merged
Merged
Commits on Nov 5, 2020
-
Expose module signature when typing implementation
While working on a new backend for OCaml to generate Erlang sources, I found the need to read the .cmi file back into a `Types.signature` value. @Drup spotted that I was reading the file and pointed out this value was already being read during the type checking process. A quick check at the `Typedtree.module_coercion` showed us that it would be difficul to extract the same information that is readily available in the signature value. This change will expose the signature value directly, so other backends relying on this signature information do not need to do the extra work of reading it again.
Configuration menu - View commit details
-
Copy full SHA for 3a125b8 - Browse repository at this point
Copy the full SHA 3a125b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6e428a - Browse repository at this point
Copy the full SHA f6e428aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be9e19 - Browse repository at this point
Copy the full SHA 3be9e19View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2f3b4 - Browse repository at this point
Copy the full SHA ee2f3b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b085d3 - Browse repository at this point
Copy the full SHA 1b085d3View commit details
Commits on Nov 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b91a90a - Browse repository at this point
Copy the full SHA b91a90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b7aff - Browse repository at this point
Copy the full SHA a0b7affView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4143fd - Browse repository at this point
Copy the full SHA f4143fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5278e3f - Browse repository at this point
Copy the full SHA 5278e3fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.