Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose module signature when typing implementation #10007

Merged
merged 9 commits into from
Nov 22, 2020

Commits on Nov 5, 2020

  1. Expose module signature when typing implementation

    While working on a new backend for OCaml to generate Erlang sources, I
    found the need to read the .cmi file back into a `Types.signature`
    value.
    
    @Drup spotted that I was reading the file and pointed out this value was
    already being read during the type checking process.
    
    A quick check at the `Typedtree.module_coercion` showed us that it would
    be difficul to extract the same information that is readily available in
    the signature value.
    
    This change will expose the signature value directly, so other backends
    relying on this signature information do not need to do the extra work
    of reading it again.
    leostera committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    3a125b8 View commit details
    Browse the repository at this point in the history
  2. Introduce typed_impl record

    leostera committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    f6e428a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3be9e19 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee2f3b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1b085d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Fix linting errors

    leostera committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b91a90a View commit details
    Browse the repository at this point in the history
  2. Fix .depend file

    No change entry needed
    leostera committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a0b7aff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4143fd View commit details
    Browse the repository at this point in the history
  4. Fix typo checks

    leostera committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    5278e3f View commit details
    Browse the repository at this point in the history