Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unix.realpath. #10047

Merged
merged 9 commits into from
Mar 30, 2021
Merged

Add Unix.realpath. #10047

merged 9 commits into from
Mar 30, 2021

Commits on Mar 25, 2021

  1. Add Unix.realpath. 

    Binds to realpath(3) on POSIX and GetFinalPathNameByHandle on
Windows.
    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    62b946e View commit details
    Browse the repository at this point in the history

  2. Address a first round of comments.

    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f8feb51 View commit details
    Browse the repository at this point in the history

  3. Add a test.

    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    58955bf View commit details
    Browse the repository at this point in the history

  4. Fix realpathing directories on Windows as suggested by @dra27.

    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    21971ba View commit details
    Browse the repository at this point in the history

  5. Windows: drop the fileapi.h header. It's not needed.

    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    03a4519 View commit details
    Browse the repository at this point in the history

  6. Allow Windows realpath to work on inaccessible files (like POSIX). 

    As suggested by @dra27.
    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    798f6f1 View commit details
    Browse the repository at this point in the history

  7. Allow Windows realpath to work on open files. 

    As suggested by @dra27.
    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7ca6ecf View commit details
    Browse the repository at this point in the history

  8. On Windows realpath strip the \\?\ prefix. 

    As suggested by @dra27.
    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    ea07e45 View commit details
    Browse the repository at this point in the history

  9. Adjust changes.

    @dbuenzli
    dbuenzli committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    364ffed View commit details
    Browse the repository at this point in the history