-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify toploop.mli / opttoploop.mli #10061
Merged
Merged
Commits on Nov 30, 2020
-
Unify toploop.mli / opttoploop.mli
This unifies both implementations of the toplevel under a common interface. Similar Makefile hacks to those in place for dynlink are used: byte and native implementations are in separate directories, while the shared interface are in the parent and copied as needed by the build rules. This is a preliminary step to remove duplication as much as possible in the two implementations, but should already be pretty useful for libraries that use the `Toploop` interface.
Configuration menu - View commit details
-
Copy full SHA for 1e35637 - Browse repository at this point
Copy the full SHA 1e35637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9225ab1 - Browse repository at this point
Copy the full SHA 9225ab1View commit details
Commits on Dec 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3ce7a31 - Browse repository at this point
Copy the full SHA 3ce7a31View commit details
Commits on Dec 3, 2020
-
Cleanup toplevel byte/native Makefile copy rules
Copying the file separately causes issues (there would be two paths to build `toplevel/byte/toploop.cmi`); this feels a bit cleaner, but the rules are not guarded anymore; it is ok because of the dependency rules ensuing from our `beforedepend` rule.
Configuration menu - View commit details
-
Copy full SHA for a7a1f30 - Browse repository at this point
Copy the full SHA a7a1f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4081bc5 - Browse repository at this point
Copy the full SHA 4081bc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b498655 - Browse repository at this point
Copy the full SHA b498655View commit details
Commits on Dec 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e17b59d - Browse repository at this point
Copy the full SHA e17b59dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9029d91 - Browse repository at this point
Copy the full SHA 9029d91View commit details
Commits on Dec 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2803a6e - Browse repository at this point
Copy the full SHA 2803a6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d114d6 - Browse repository at this point
Copy the full SHA 2d114d6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.