Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a -timeout option to ocamltest #10113

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Add a -timeout option to ocamltest #10113

merged 4 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. ocamltest: add option -timeout and "timeout" variable 

    This option sets a timeout (in seconds) that is applied to every external
command run from ocamltest.

It is useful to catch test that don't terminate and report them as
failing.

This is implemented by an ocamltest variable called "timeout"
whose initial value is that given by the -timeout option,
or 0 (no timeout) otherwise.

Co-authored-by: Gabriel Scherer <gabriel.scherer@gmail.com>
    @xavierleroy @gasche
    xavierleroy and gasche committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    fddee4c View commit details
    Browse the repository at this point in the history

  2. ocamltest Win32: fix timeout handling 

    The original code caused the timeout duration to drop to 0 at some
of the spurious wake-ups, hence the command would time out early.

The new code uses GetTickCount64() instead of GetTickCount() to avoid
issues with GetTickCount() overflowing and wrapping around.
(As suggested by David Allsopp.)
    @xavierleroy
    xavierleroy committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    1f5c34a View commit details
    Browse the repository at this point in the history

  3. Set a timeout for ocamltest invocations 

    By default, we allow a generous 10 minutes (600 seconds).

Can be overriden with `make TIMEOUT=...`.
    @xavierleroy
    xavierleroy committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    c569899 View commit details
    Browse the repository at this point in the history

  4. Changes for ocaml#10113

    @xavierleroy
    xavierleroy committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a00308f View commit details
    Browse the repository at this point in the history