-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor clean-ups in runtime/io.c and runtime/caml/io.h #10136
Merged
Merged
Commits on Jan 8, 2021
-
Remove the "for Cash only" fields
revealed
andold_revealed
Cash (http://pauillac.inria.fr/cash/) was an experiment in using OCaml for shell scripting. The project is no longer active and the old code does not compile with OCaml 4.
Configuration menu - View commit details
-
Copy full SHA for 9656815 - Browse repository at this point
Copy the full SHA 9656815View commit details
Commits on Jan 21, 2021
-
Refactor caml_ml_close_channel
Control flow can be simplified, removing the `do_syscall` variable.
Configuration menu - View commit details
-
Copy full SHA for c2f42c7 - Browse repository at this point
Copy the full SHA c2f42c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf8e44c - Browse repository at this point
Copy the full SHA bf8e44cView commit details -
Turn caml_getch and caml_putch into functions
These I/O operations used to be defined as macros in <caml/io.h>, but they are not speed-critical, so it's cleaner to have them as functions, like all other I/O operations in this file.
Configuration menu - View commit details
-
Copy full SHA for f7e32a3 - Browse repository at this point
Copy the full SHA f7e32a3View commit details
Commits on Jan 24, 2021
-
In out_channels_list, report channels opened from OCaml only
Previously, output channels opened from C were also reported in this list, causing `Stdlib.flush_all` to flush them. This feels wrong, as channels opened from C are entirely managed from C code. With this commit, output channels opened from C always have a reference count of 0: `caml_alloc_channel` is no longer called with one of these channels, and it's the only function that increases refcount. Hence the refcount check in `caml_close_channel` can be removed.
Configuration menu - View commit details
-
Copy full SHA for aeb785e - Browse repository at this point
Copy the full SHA aeb785eView commit details -
`caml_allc_custom_mem` cannot trigger finalization any longer.
Configuration menu - View commit details
-
Copy full SHA for 6021888 - Browse repository at this point
Copy the full SHA 6021888View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07c3295 - Browse repository at this point
Copy the full SHA 07c3295View commit details -
Configuration menu - View commit details
-
Copy full SHA for 691655c - Browse repository at this point
Copy the full SHA 691655cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.