Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #10183

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix CI #10183

merged 2 commits into from
Feb 1, 2021

Conversation

Octachron
Copy link
Member

This PR hopefully fixes the current state of the CI by synchronizing the Unix library documentation (#10181) and avoiding accidental copies in the toplevel directory (#10124).

Note: this is a synchronization PR to avoid potential duplicated work while waiting for the CI return.

Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mea maxima culpa for not having synchronized unixLabels.mli. The idea did cross my mind, but was quickly forgotten :-(

@xavierleroy
Copy link
Contributor

Note that the i386-static CI fails with an unrelated? issue:

Files toplevel/toploop.cmo and toplevel/byte/topeval.cmo
       make inconsistent assumptions over interface Topeval

Could it be that someone else forgot to update the OCaml dependencies?

@Octachron
Copy link
Member Author

The Makefile simplification in the second commit was visibly too aggressive. I am currently running an amended fix in parallel.

@Octachron
Copy link
Member Author

Merged to restore CI (cc @shindere).

@shindere
Copy link
Contributor

shindere commented Feb 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants