-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split labels and polymorphic variants tutorials; move GADTs into tutorial #10206
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0895c08
Split Labels / Variants chapter into two
johnwhitington cc7a700
Move GADT tutorial into the tutorials
johnwhitington 3138478
Fixing sections and subsections
johnwhitington 803967d
Merge branch 'trunk' into split-labs
johnwhitington c73cb1e
typo
johnwhitington 7184392
Merge branch 'split-labs' of https://github.com/johnwhitington/ocaml …
johnwhitington 077103f
Merge branch 'trunk' of https://github.com/ocaml/ocaml into split-labs
johnwhitington f1448b8
Adds Changes entry
johnwhitington 551462e
Reorder chapters
johnwhitington 18c50d2
Make beginning less abrupt
johnwhitington f59bf7b
Merge branch 'trunk' into split-labs
johnwhitington 03dae97
Adjust reference to manual chapters in error messages
Octachron 9521629
Merge branch 'trunk' into split-labs
Octachron 33d231f
Fix mistake with subsection
Octachron File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refuation ⇒ Refutation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. By the way, your Stackoverflow answer here could be repurposed to improve the refutation explanation in the tutorial, if you have any time to do it:
https://stackoverflow.com/questions/52795191/when-are-refutation-cases-necessary-in-ocaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good idea, I will have a look.