Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Windows debugger socket setup #10212

Merged
merged 4 commits into from
Feb 23, 2021

Commits on Feb 16, 2021

  1. Simplify Windows debugger socket setup

    Don't use SO_OPENTYPE in Windows debugger. It was probably deprecated
    at some point, and the same feature can be achieved with WSASocket.
    
    The documentation reads (about SO_OPENTYPE):
    
    > Once set, affects whether subsequent sockets that are created will
    > be non-overlapped. The possible values for this option are
    > SO_SYNCHRONOUS_ALERT and SO_SYNCHRONOUS_NONALERT. This option should
    > not be used. Instead use the WSASocket function and leave the
    > WSA_FLAG_OVERLAPPED bit in the dwFlags parameter turned off.
    
    https://docs.microsoft.com/en-us/windows/win32/winsock/sol-socket-socket-options
    
    This allows to merge Windows-specific code and to remove all the
    sockopt related code. Keeping the _open_osfhandle error is not
    necessary.
    
    No change entry needed
    MisterDA committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e13bd18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b33490 View commit details
    Browse the repository at this point in the history
  3. Wrong error test

    xavierleroy committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c674336 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Changes for ocaml#10212

    xavierleroy committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    4bfe13d View commit details
    Browse the repository at this point in the history