Simplify Typedecl_separability unboxed types handling #10248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stedolan
force-pushed
the
simplify-unboxed-separability
branch
from
db7dbeb
to
c35347c
Compare
|
#10232 caught these too, although I took out slightly less. |
gasche
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
This looks correct and indeed it removes code. The data that was there would be useful to print proper error messages when [@@unboxed] fails, but nobody worked on this. I have mixed feelings about losing this information, but I guess that's an okay thing to do. Approved.
garrigue
pushed a commit
to garrigue/ocaml
that referenced
this pull request
Mar 3, 2021
smuenzel
pushed a commit
to smuenzel/ocaml
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the handling of unboxed types in Typedecl_separability by removing some unused fields and data structures, and the code to compute them.