Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

floats.c: small optim of caml_{frexp,modf}_float #10398

Merged
merged 2 commits into from
May 6, 2021
Merged

floats.c: small optim of caml_{frexp,modf}_float #10398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1adba9d
floats.c: small optim of caml_{frexp,modf}_float
nojb May 6, 2021
15163e9
Changes
nojb May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ Working version
- #882: Add fold_left, fold_right, exists and for_all to String/Bytes
(Yotam Barnoy, review by Alain Frisch and Jeremy Yallop)

- #4070, #10398: small optimization of Stdlib.{frexp,modf}.
(Markus Mottl, Nicolás Ojeda Bär, review by Gabriel Scherer)

### Other libraries:

- #10047: Add `Unix.realpath`
Expand Down
15 changes: 8 additions & 7 deletions runtime/floats.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,12 +746,13 @@ CAMLprim value caml_fmod_float(value f1, value f2)

CAMLprim value caml_frexp_float(value f)
{
CAMLparam1 (f);
CAMLlocal2 (res, mantissa);
CAMLparam0 ();
CAMLlocal1 (mantissa);
value res;
int exponent;

mantissa = caml_copy_double(frexp (Double_val(f), &exponent));
res = caml_alloc_tuple(2);
res = caml_alloc_small(2, 0);
Field(res, 0) = mantissa;
Field(res, 1) = Val_int(exponent);
CAMLreturn (res);
Expand Down Expand Up @@ -781,14 +782,14 @@ CAMLprim value caml_log10_float(value f)

CAMLprim value caml_modf_float(value f)
{
CAMLparam0 ();
CAMLlocal2 (quo, rem);
value res;
double frem;

CAMLparam1 (f);
CAMLlocal3 (res, quo, rem);

quo = caml_copy_double(modf (Double_val(f), &frem));
rem = caml_copy_double(frem);
res = caml_alloc_tuple(2);
res = caml_alloc_small(2, 0);
Field(res, 0) = quo;
Field(res, 1) = rem;
CAMLreturn (res);
Expand Down