Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix work accounting in marking phase #10449

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix work accounting in marking phase #10449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ OCaml 4.13.0
- #10376: Link runtime libraries correctly on msvc64 in -output-complete-obj
(David Allsopp, review by Gabriel Scherer)

- #xxx: Fix major GC work accounting (the GC was running too fast).
(Damien Doligez, report by Stephen Dolan, review by xxx)

OCaml 4.12.0 (24 February 2021)
-------------------------------

Expand Down
2 changes: 1 addition & 1 deletion runtime/major_gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ Caml_inline void mark_slice_darken(struct mark_stack* stk, value v, mlsize_t i,
if( Tag_hd(chd) < No_scan_tag ) {
mark_stack_push(stk, child, 0, work);
} else {
*work -= 1; /* Account for header */
*work -= Whsize_hd (chd);
}
}
}
Expand Down