Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of iconv on Cygwin and build performance regression on Windows #10451

Merged
merged 2 commits into from
Sep 1, 2021

Commits on Apr 28, 2021

  1. Use build_config.h instead of -DOCAML_STDLIB_DIR

    Cygwin no longer provides the iconv command by default, which means the
    translation of LIBDIR into OCAML_STDLIB_DIR cannot be guaranteed to
    succeed. Technically, an unusual PREFIX could also result in an invalid
    C constant in the Unix build.
    
    Introduce a (relatively) small C program to carry out the function of
    iconv and also translate the constant on the Unix side as well.
    dra27 committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    88676f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. Compute STDLIB_MODULES with a C auxiliary

    Eliminates the dependency on many invocations of `tr` and `cut` to a
    single invocation of a C auxiliary.
    
    On Windows, the C auxiliary is considerably faster than the large number
    of calls to tr and cut which were necessary in stdlib/StdlibModules.
    dra27 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    1c7e469 View commit details
    Browse the repository at this point in the history