Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS adjustments in post-processed HTML manual #10497

Merged
merged 19 commits into from
Aug 18, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions manual/src/html_processing/scss/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -793,8 +793,7 @@

code span.constructor,
.caml-input span.kw2 {
font-weight: 500;
color: #a28867;
color: #8d543c;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the number of colors seems fine, but what is the reasoning behind reducing the font weight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have had another reason I can't remember, but I don't see why it would be bolded in the first place and it's not bolded in htmlman. I think now only keywords like let and while are bolded, which I think is standard when displaying code.

It's also annoying that .constructor in the HTML applies to both data constructors and modules, having a different style for modules (maybe just bolded) would be nice.

}

.caml-input span.numeric {
Expand Down