Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS adjustments in post-processed HTML manual #10497

Merged
merged 19 commits into from
Aug 18, 2021
Merged

CSS adjustments in post-processed HTML manual #10497

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f8390bc
webman: Remove colored background for inline code
wikku Jul 9, 2021
a194d25
webman: Follow inline code styling of htmlman
wikku Jul 9, 2021
ef6d050
webman: Italicize grammar symbol names
wikku Jul 9, 2021
d5fe429
webman: Make display style blocks centered
wikku Jul 9, 2021
61764cc
webman: Increase heading font-weight
wikku Jul 9, 2021
8900ac5
webman: Use SCSS variables for font-family
wikku Jul 14, 2021
b4eb567
webman: Set command-line arguments in monospace
wikku Jul 14, 2021
a50a4d4
webman: Set (mathematical) variables in italics
wikku Jul 14, 2021
cfd3c03
webman: Remove styling for the ordinal "th"
wikku Jul 14, 2021
7c1fd96
webman/api: Improve constructor color contrast
wikku Jul 14, 2021
e311dab
webman: Center tables
wikku Jul 20, 2021
afe24ba
webman: Make table headers bold
wikku Jul 20, 2021
f6355cf
webman: Fix variables being bolded, not italicized
wikku Jul 20, 2021
cfb2545
webman: Add spacing to tables for aligned exprs
wikku Jul 20, 2021
321a227
webman: Add padding to .cellpadding1
wikku Jul 20, 2021
27ae0f5
webman: Styling for Unix/Windows specific blocks
wikku Jul 20, 2021
d56cbd0
webman: Italicize command-line argument variables
wikku Jul 20, 2021
49b9cd3
webman: Center BNF syntax bars `|`
wikku Jul 20, 2021
9671c87
Add Changes entry
wikku Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions manual/src/html_processing/scss/manual.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,14 @@ blockquote.quote{
color:#000;
&::before{@include diamond}
}
.center {
text-align: center;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horizontally aligning text on the center seems like a mistake outside of tables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to center the displayed syntax fragments, as in the screenshot. These rules are just copied from the old HTML manual CSS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that having some indenting would be better than centering texts.

margin-left: auto;
margin-right: auto;
}
.display {
margin: 0 auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old manual css this styling was on .dcenter which seems a little bit clearer in term of intents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classes .display and .dcenter seem to always coexist, so it doesn't really matter. I don't think it's clearer, they're just different approaches ("semantic" vs "non-semantic" CSS)

}
span.c003{
color:#564233;
font-family:"Fira Mono",courier;
Expand Down