-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Out_channel.{is,set}_buffered
to control buffering of output channels
#10538
Merged
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e9f72fe
io.c: allow unbuffered output channels
nojb 2c01396
If connected to a terminal, set stderr to be unbuffered
nojb 74ba8b4
Set stderr to be unbuffered unconditionally
nojb cd7a450
Expose function to control buffering mode, do not change stderr by de…
nojb f7ca145
Changes
nojb 0044592
check-typo
nojb c162de6
Accept test results
nojb 75cc396
Flush channel when set to unbuffered
nojb 69de4b8
Rename set_channel_{unbuffered => buffered}
nojb 86d604c
Move function to Out_channel
nojb ff2fd93
Use macro for clarity
nojb 9a6ee94
Reduce diff
nojb 836aeea
Changes
nojb cceff43
Call caml_ml_flush instead of caml_flush
nojb a68ae80
Rename set_buffering_mode => set_buffered
nojb e2cd884
Add Out_channel.is_buffered
nojb b69e842
Changes
nojb 14abf4b
Doc
nojb 004afae
Add test
nojb e1bc6fa
Use !
nojb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, it's OK to update the channel's flags without registering a root on
vchannel
and locking the channel, but I think you need to do have done both in order to callcaml_flush
on it. Simplest to callcaml_ml_flush
therefore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.