Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Changes, LICENSE, and READMEs #10669
Install Changes, LICENSE, and READMEs #10669
Changes from 8 commits
8b458c5
2dc83d2
ff6bb64
791232d
fd42adf
1de2196
0640438
f682f71
f4ff24b
46eb9ff
f1d4f46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
--docdir=%{ocaml:doc}%
(or--docdir=%{_:doc}%
but I can't find it in the documentation, I'm no longer sure if that's the right syntax to not mention the package name in theopam
file).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed. The doc for the
%{_:var}%
syntax seems to be https://opam.ocaml.org/doc/Manual.html#Scopes, I didn't see anything that would make me believe that one should not use this syntax in theopam
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the actual path which is wanted?
%{_:doc}%
should install it todoc/ocaml-variants
in the switch (so it would bedoc/ocaml-base-compiler
in a released compiler). Does this difference matter? I'm not sure if%{ocaml:doc}%
works at this stage (it shouldn't, because theocaml
package is installed afterocaml-variants
, but it might becausepost
dependencies are weird).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, I'm so ignorant about
opam
:(I think that what we want is to install it in
${prefix}/doc/ocaml
. This last change was an attempt at producing this exact path without hardcoding it. @dbuenzli do you agree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really want them in
opam var ocaml:doc
, I didn't know about these packaging convolutions. So maybe what @nojb had written in the first place is best. (Sorry for the noise).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually rather than what he wrote originally
%{doc}%/ocaml/
would be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, amended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ignorance - it's a really obscure opam corner!