Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong unmarshaling of function pointers in debugger mode #10709

Merged
merged 4 commits into from
Oct 19, 2021

Commits on Oct 18, 2021

  1. Wrong unmarshaling of function pointers in debugger mode

    In debugger mode, closures sent by the debuggee have their code pointer
    modified so that it points to the `function_placeholder` code in
    debugger/main.ml.
    
    This modification was performed incorrectly: the whole closure for
    `function_placeholder` was used as the code pointer for the
    unmarshalled closure.
    
    This commit implements the correct operation: the code pointer from
    `function_placeholder` is used as code pointer for the unmarshaled
    closure.
    
    Fixes: ocaml#9214
    xavierleroy committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    bfb03c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab9588c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Wrong unmarshaling of function pointers in debugger mode, continued

    Use Code_val(v) instead of Field(v, 0) to make intent clearer.
    xavierleroy committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    aab79fd View commit details
    Browse the repository at this point in the history
  2. Changes for ocaml#10709

    xavierleroy committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a8d09d4 View commit details
    Browse the repository at this point in the history