Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name expressions after typing in ocamlnat (restores equivalence with bytecode toplevel) #10712

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Name expressions after typing in ocamlnat (restores equivalence with bytecode toplevel) #10712

merged 4 commits into from
Jan 4, 2022

Commits on Jan 4, 2022

  1. Fix type variable naming in native toplevel 

    This was written by @lpw25 . It makes the native toplevel preserve type variable
names in the same way as the bytecode toplevel.

This patch was originally submitted to flambda-backend

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
    @NathanReb @dra27
    NathanReb authored and dra27 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    d1bffec View commit details
    Browse the repository at this point in the history

  2. Add toplevel.opt test to ocamltest 

    The individual stages were all there, but we don't have an explicit test
for the native toplevel.
    @dra27
    dra27 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    b1664d4 View commit details
    Browse the repository at this point in the history

  3. Add test

    @dra27
    dra27 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    a52c230 View commit details
    Browse the repository at this point in the history

  4. Add comments explaining native code differences 

    Explains both why ocamlnat needs to name certain expressions and also
why this is now done after typing rather than before.
    @dra27
    dra27 committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    9218130 View commit details
    Browse the repository at this point in the history