Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash in Obj.reachable_words #10853

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Fix a crash in Obj.reachable_words #10853

merged 3 commits into from
Jan 6, 2022

Commits on Jan 6, 2022

  1. Repro case for a bug in caml_obj_reachable_size 

    From ocaml-multicore/ocaml-multicore#824
    @xavierleroy
    xavierleroy committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    e55aa00 View commit details
    Browse the repository at this point in the history

  2. Missing initialization in caml_obj_reachable_words 

    A marshaling operation can leave `extern_flags` with the `NO_SHARING`
bit set.  In this context, `caml_obj_reachable_words` calls
`extern_init_position_table`, which does nothing, then proceeds to
access the position table, causing a crash.

The solution is trivial: initialize `extern_flags` before calling
`extern_init_position_table`.

First reported at ocaml-multicore/ocaml-multicore#824
    @xavierleroy
    xavierleroy committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7d71be1 View commit details
    Browse the repository at this point in the history

  3. Changes for ocaml#10853

    @xavierleroy
    xavierleroy committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    8a0ee13 View commit details
    Browse the repository at this point in the history