-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the Thread.Exit exception #10951
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 8 additions & 5 deletions
13
testsuite/tests/lib-threads/uncaught_exception_handler.reference
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
Thread 1 killed on uncaught exception Uncaught_exception_handler.CallbackExn | ||
Raised at Uncaught_exception_handler.fn in file "uncaught_exception_handler.ml", line 28, characters 12-113 | ||
Called from Thread.create.(fun) in file "thread.ml", line 47, characters 8-14 | ||
Called from Thread.create.(fun) in file "thread.ml", line 49, characters 8-14 | ||
[thread 2] caught Uncaught_exception_handler.CallbackExn | ||
Raised at Uncaught_exception_handler.fn in file "uncaught_exception_handler.ml", line 28, characters 12-113 | ||
Called from Thread.create.(fun) in file "thread.ml", line 47, characters 8-14 | ||
Called from Thread.create.(fun) in file "thread.ml", line 49, characters 8-14 | ||
Thread 2 killed on uncaught exception Uncaught_exception_handler.CallbackExn | ||
Raised at Uncaught_exception_handler.fn in file "uncaught_exception_handler.ml", line 28, characters 12-113 | ||
Called from Thread.create.(fun) in file "thread.ml", line 47, characters 8-14 | ||
Called from Thread.create.(fun) in file "thread.ml", line 49, characters 8-14 | ||
Thread 2 uncaught exception handler raised Uncaught_exception_handler.UncaughtHandlerExn | ||
Raised at Uncaught_exception_handler.handler in file "uncaught_exception_handler.ml", line 26, characters 2-26 | ||
Called from Thread.create.(fun) in file "thread.ml", line 53, characters 10-41 | ||
Raised at Uncaught_exception_handler.handler in file "uncaught_exception_handler.ml", line 26, characters 2-17 | ||
Called from Thread.create.(fun) in file "thread.ml", line 58, characters 10-41 | ||
[thread 3] caught Uncaught_exception_handler.CallbackExn | ||
Raised at Uncaught_exception_handler.fn in file "uncaught_exception_handler.ml", line 28, characters 12-113 | ||
Called from Thread.create.(fun) in file "thread.ml", line 49, characters 8-14 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this 4.14 version, this wording might give the impression that the
exit
function raises this exception which is not the case.Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right. I improved the wording along your lines. Thanks!