Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10836: recognize unrecoverable errors in the signature inclusion check #10952

Merged
merged 7 commits into from
Feb 3, 2022
Merged

#10836: recognize unrecoverable errors in the signature inclusion check #10952

merged 7 commits into from
Feb 3, 2022

Commits on Feb 3, 2022

  1. Recognize unrecoverable errors in Includemod 

    Stop the computation of a signature difference when the types start to diverge
in order to avoid trying to typecheck items in incoherent environments.

See ocaml#10836
    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    cca40bb View commit details
    Browse the repository at this point in the history

  2. review: rename mark_error_as_{un,}recoverable

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    0310f6f View commit details
    Browse the repository at this point in the history

  3. review: rename unknowns field to leftovers

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7e82486 View commit details
    Browse the repository at this point in the history

  4. review: more records

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    bcb1a09 View commit details
    Browse the repository at this point in the history

  5. update Changes

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    fce7ee9 View commit details
    Browse the repository at this point in the history

  6. review: more linear code flow in Includemod.signature_components

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    6486db8 View commit details
    Browse the repository at this point in the history

  7. review: last changes

    @Octachron
    Octachron committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4ff192d View commit details
    Browse the repository at this point in the history