Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass -no-pie to the C compiler on musl/arm64 part 2 #11036

Merged
merged 3 commits into from
Feb 27, 2022
Merged

Do not pass -no-pie to the C compiler on musl/arm64 part 2 #11036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ccec82
Do not pass `-no-pie` to the C compiler on musl/arm64 part 2
anmonteiro Feb 20, 2022
2028838
changes entry
anmonteiro Feb 20, 2022
f9d0aec
Apply suggestions from code review
anmonteiro Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ Working version

### Bug fixes:

- #11025: Do not pass -no-pie to the C compiler on musl/arm64
(omni and Kate Deplaix, review by Xavier Leroy)
- #11025, #11036: Do not pass -no-pie to the C compiler on musl/arm64
(omni, Kate Deplaix and Antonio Nuno Monteiro, review by Xavier Leroy)

OCaml 4.14.0
----------------
Expand Down
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ AS_IF([test -z "$PARTIALLD"],
# e.g. Ubuntu >= 17.10 for i386, which uses the glibc dynamic loader.

AS_CASE([$arch],
[amd64|aarch64|s390x|none],
[amd64|arm64|s390x|none],
# ocamlopt generates PIC code or doesn't generate code at all
[],
[AS_CASE([$host],
Expand Down