better pretty-printing of module shapes #11697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Remember: "shapes" are an abstraction of the module structure of OCaml programs introduced in #10718.)
I am trying again to understand what it is about the Irmin source code that made earlier implementations of shape-reduction blow up. This involves looking at the
-dshape
output for a manually-minized subset ofirmin.ml
, whose printing starts like this:(I won't show the whole output because it takes 2GiB.)
This PR introduces a compact notation for n-ary functors (and reduces the structure indentation slightly).
-dshape
then gives the following result:which is much nicer to read and work with.