Add {In,Out}_channel.is_binary_mode
#12845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojb
approved these changes
Dec 19, 2023
xavierleroy
approved these changes
Dec 19, 2023
stdlib/in_channel.mli
Outdated
Comment on lines
215
to
216
| @since 5.3 *) | ||
|
|
There was a problem hiding this comment.
It might still be time to sneak this into 5.2, with @Octachron 's approval.
dra27
force-pushed
the
get_binary_mode
branch
from
81fb3c7
to
dff69c8
Compare
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further follow-on to the story of #12792. There are (good) ways of not needing to know the binary mode of a channel, but they mostly involve using the Unix library. In these guilt-free post-#10545 times, it seems we could risk having
is_binary_modeas the dual ofset_binary_modeinIn_channelandOut_channelin the same way as we haveOut_channel.is_bufferedas the dual ofOut_channel.set_buffered. Further, the function to get that mode was already exposed in the runtime's C API.