Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure env vars don't exist prior to win-env test #1599

Merged
merged 10 commits into from
Jul 20, 2021
Merged

Ensure env vars don't exist prior to win-env test #1599

merged 10 commits into from
Jul 20, 2021

Commits on Jul 10, 2021

  1. Eliminate open Unix from testsuite 

    Mildly useful to be able to grep functions with Unix.foo
    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    e7161fd View commit details
    Browse the repository at this point in the history

  2. Harden win-unicode test against putenv failure 

    Rather than cleaning the environment in advance, use Unix.putenv twice,
so the environment could only possilby be initialised to one false
positive!
    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    0fc19c0 View commit details
    Browse the repository at this point in the history

  3. Add unset directive to ocamltest 

    unset erases the given variable from the environment.
    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    30256c0 View commit details
    Browse the repository at this point in the history

  4. Use unset in the testsuite to harden tests

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    791dd86 View commit details
    Browse the repository at this point in the history

  5. Correct indentation of function clauses

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    bc527fc View commit details
    Browse the repository at this point in the history

  6. Changes

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    551af34 View commit details
    Browse the repository at this point in the history

  7. Environments.remove -> Environments.unsetenv

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    39d29be View commit details
    Browse the repository at this point in the history

  8. Use for instead of while for stepwise loops

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    de11da3 View commit details
    Browse the repository at this point in the history

  9. Always restore alteration to environment string

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    24f565b View commit details
    Browse the repository at this point in the history

  10. Use DOES_NOT_EXIST to clarify expectation

    @dra27
    dra27 committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    80a4037 View commit details
    Browse the repository at this point in the history