output-complete-obj: link runtime C libraries when building shared libraries #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
18 months later, is this PR still relevant? @Octachron, you're in control, do what it takes. |
|
It looks to me like this PR is still relevant and has not been invalidated by recent developments around (cc @nojb ?) |
|
I had taken a look at this some time back and it seemed OK. I will do a formal review shortly. |
nojb
approved these changes
Nov 8, 2019
This commit align the behavior of output-complete-obj and output-obj when building shared libraries
Octachron
force-pushed
the
monotonic_ouput-complete-obj
branch
from
f38e49b
to
dcebfa1
Compare
|
I somehow completely missed this ping, sorry! I updated the Change entry and will merge (once the CI is green). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus PR is an offspring of #1351 : currently, when building a shared library with
-output-objor-output-complete-obj:the only difference between
-output-objandoutput-complete-objis that-output-complete-objdoes not link the C libraries used by the runtime by default. The fact that thecompletevariant links less objects than the simple variant is not intuitive at all — as illustrated by the discussion in #1351 .Moreover, @whitequark confirmed that this behavior was not really intended and was inherited from the static linking mode.
Consequently, this small PR proposes to align the behavior of
-output-complete-objto the behavior ofoutput-objand link these runtime C libraries in the shared library mode.