-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9116: Error source highlighting in presence of tabs #9118
Open
Armael
wants to merge
9
commits into
ocaml:trunk
Choose a base branch
from
Armael:fix-9116
base: trunk
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 17, 2019
-
Add a test for error highlighting in presence of tabs
Armaël Guéneau committedNov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for cfa78b3 - Browse repository at this point
Copy the full SHA cfa78b3View commit details -
Error source highlighting: align using tabs to match tabs in the source
Fixes ocaml#9116
Armaël Guéneau committedNov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 87caeef - Browse repository at this point
Copy the full SHA 87caeefView commit details -
Add a test for multiline errors involving tabs
Armaël Guéneau committedNov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 60bbe8e - Browse repository at this point
Copy the full SHA 60bbe8eView commit details -
Tweak the highlighting of source code on multiple lines
Display blank characters (' ' or '\t') as themselves instead of '.' to avoid messing with the alignment in presence of tabs.
Armaël Guéneau committedNov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 1d3f259 - Browse repository at this point
Copy the full SHA 1d3f259View commit details -
Armaël Guéneau committed
Nov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 9f5a214 - Browse repository at this point
Copy the full SHA 9f5a214View commit details -
Armaël Guéneau committed
Nov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for c1e4ece - Browse repository at this point
Copy the full SHA c1e4eceView commit details -
Armaël Guéneau committed
Nov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for d6c8bf2 - Browse repository at this point
Copy the full SHA d6c8bf2View commit details -
check-typo: highlight_tabs.ml contains tabs
Armaël Guéneau committedNov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 453f8f1 - Browse repository at this point
Copy the full SHA 453f8f1View commit details -
Armaël Guéneau committed
Nov 17, 2019 Configuration menu - View commit details
-
Copy full SHA for cffb75f - Browse repository at this point
Copy the full SHA cffb75fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.