Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic diffings for functor types and applications #9331

Merged
merged 92 commits into from
Apr 7, 2021
Merged

Semantic diffings for functor types and applications #9331

merged 92 commits into from
Apr 7, 2021

Commits on Mar 12, 2021

  1. Add module to compute edit distance generically.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b60bb45 View commit details
    Browse the repository at this point in the history

  2. Expose printers for module exprs.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    5790a79 View commit details
    Browse the repository at this point in the history

  3. Add tag for direct styled output.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2fed5ec View commit details
    Browse the repository at this point in the history

  4. Fix format boxes in Includecode.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    986f64e View commit details
    Browse the repository at this point in the history

  5. Add printers for functor parameters without a returned signature.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    190102e View commit details
    Browse the repository at this point in the history

  6. Improve error messages for functor signatures and applications. 

    Also improve module type equality errors.
    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    cc46c93 View commit details
    Browse the repository at this point in the history

  7. Add tests for functor signature and parameter errors.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d2bb124 View commit details
    Browse the repository at this point in the history

  8. add an example of variadic functor

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    685525a View commit details
    Browse the repository at this point in the history

  9. Changes for functor errors.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ef0aa4f View commit details
    Browse the repository at this point in the history

  10. update dune file

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d2c6163 View commit details
    Browse the repository at this point in the history

  11. Compute list elements earlier with Includemod.dlist

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7d63058 View commit details
    Browse the repository at this point in the history

  12. Split the application and inclusion update 

    This is nearly necessary to avoid mixing different concerns
and concepts together
    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a5c886e View commit details
    Browse the repository at this point in the history

  13. Edit_distance with dynamical resizing 

    Co-authored-by: Gabriel Radanne <drupyog@zoho.com>
    @Octachron @Drup
    Octachron and Drup committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    35ab293 View commit details
    Browse the repository at this point in the history

  14. Pretty error message for variadic functors

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a11943b View commit details
    Browse the repository at this point in the history

  15. More test for exotic functors

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c3a3871 View commit details
    Browse the repository at this point in the history

  16. Pretty error message for variadic functor inclusion

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f67af41 View commit details
    Browse the repository at this point in the history

  17. Fix missing cmi case 

    Make the handling of abstract module types clearer
    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    38ff391 View commit details
    Browse the repository at this point in the history

  18. Improved functor errors with extra arguments 

    Handle Map.Make(Ord)(X)(Y)(Z) and friends
    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2e8a228 View commit details
    Browse the repository at this point in the history

  19. Make the code a bit cleaner in Includemod.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    e4ba09e View commit details
    Browse the repository at this point in the history

  20. Use $name as generate name in diffing errors.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    dabfafa View commit details
    Browse the repository at this point in the history

  21. Capitalize error messages when appropriate.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    8e31ace View commit details
    Browse the repository at this point in the history

  22. Rename Compilerlibs_edit_distance into Diffing.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2c52ed0 View commit details
    Browse the repository at this point in the history

  23. Formalize the internal API for Diffing.Matrix.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b3d07bc View commit details
    Browse the repository at this point in the history

  24. Simplifies the external API for Diffing.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c270561 View commit details
    Browse the repository at this point in the history

  25. First shot at documenting Diffing.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2bb0ee1 View commit details
    Browse the repository at this point in the history

  26. Put more constraints on expansions during variadic diff.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ab2557a View commit details
    Browse the repository at this point in the history

  27. Fix a bug in the rewrite of select_best_proposition.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c659209 View commit details
    Browse the repository at this point in the history

  28. Code simplification and debugging help in Diffing.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f52d5fb View commit details
    Browse the repository at this point in the history

  29. Fix selection of final state in the diff matrix.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    3e8a605 View commit details
    Browse the repository at this point in the history

  30. Prefer diagonales when diffing.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c87f4e9 View commit details
    Browse the repository at this point in the history

  31. Add Leo's example.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    42eef42 View commit details
    Browse the repository at this point in the history

  32. More code simplification.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ba32911 View commit details
    Browse the repository at this point in the history

  33. Use more labels in Env.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a1360f1 View commit details
    Browse the repository at this point in the history

  34. Lookup all arguments of a functor prior to application in Env.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f0224af View commit details
    Browse the repository at this point in the history

  35. Fix some english.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d0ade10 View commit details
    Browse the repository at this point in the history

  36. Check typo.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    cfc6748 View commit details
    Browse the repository at this point in the history

  37. Attempt at a clearer description.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f2eb609 View commit details
    Browse the repository at this point in the history

  38. Some internal comments.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    45ef5b0 View commit details
    Browse the repository at this point in the history

  39. Shorter messages for one argument diff

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b247b01 View commit details
    Browse the repository at this point in the history

  40. Fix empty line in error messages

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    04cc60f View commit details
    Browse the repository at this point in the history

  41. Control alignment with tboxes

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    178c19f View commit details
    Browse the repository at this point in the history

  42. Fix misaligned conflict explanation

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    9284705 View commit details
    Browse the repository at this point in the history

  43. Suberrors in signature require an expansion token

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    67b83b8 View commit details
    Browse the repository at this point in the history

  44. Check typo

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7a4cab4 View commit details
    Browse the repository at this point in the history

  45. diffing: avoid copy in the non-extension case

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    310f038 View commit details
    Browse the repository at this point in the history

  46. diffing: more explict name for update kind

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    805536a View commit details
    Browse the repository at this point in the history

  47. diffing: more descriptions and some renaming

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    6576d02 View commit details
    Browse the repository at this point in the history

  48. Make the selection of final cell more principled.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    152c434 View commit details
    Browse the repository at this point in the history

  49. Fix comment.

    @Drup @Octachron
    Drup authored and Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    9ece0bd View commit details
    Browse the repository at this point in the history

  50. diffing: update printing env for functor params

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2ac73a9 View commit details
    Browse the repository at this point in the history

  51. copyright headers

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    fb6b24a View commit details
    Browse the repository at this point in the history

  52. diffing: update documentation

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ab4c5ff View commit details
    Browse the repository at this point in the history

  53. diffing: coherent functor argument printing

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    36f0463 View commit details
    Browse the repository at this point in the history

  54. diffing: add parentheses in functor (sig end)

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    43924ef View commit details
    Browse the repository at this point in the history

  55. ci: update .depend

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4f461f6 View commit details
    Browse the repository at this point in the history

  56. review: add an application summary type

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c8434c5 View commit details
    Browse the repository at this point in the history

  57. review: remode metadata type

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d8ac5f8 View commit details
    Browse the repository at this point in the history

  58. review: white spaces

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f602016 View commit details
    Browse the repository at this point in the history

  59. review: unused parameters

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4b7d5f2 View commit details
    Browse the repository at this point in the history

  60. review: use symptom uniformly

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d161f96 View commit details
    Browse the repository at this point in the history

  61. review: remove dont_match

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1e9339e View commit details
    Browse the repository at this point in the history

  62. review: simplification after dont_match_removal

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ef622b6 View commit details
    Browse the repository at this point in the history

  63. review: module types are not path

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f9e6014 View commit details
    Browse the repository at this point in the history

  64. review: style

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    6c19093 View commit details
    Browse the repository at this point in the history

  65. review: rename need_expansion

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    48937c5 View commit details
    Browse the repository at this point in the history

  66. review: Option.map formatting

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    0cd4799 View commit details
    Browse the repository at this point in the history

  67. review: Pp.{got,expected}

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    5baced3 View commit details
    Browse the repository at this point in the history

  68. review: split includemod module

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7c4cd46 View commit details
    Browse the repository at this point in the history

  69. review: split module with header files

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1bb74bb View commit details
    Browse the repository at this point in the history

  70. review: only one new module

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    62e2179 View commit details
    Browse the repository at this point in the history

  71. review: split functor diff modules

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c1c7bfc View commit details
    Browse the repository at this point in the history

  72. review: remove unused argument in functor diffs

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f219302 View commit details
    Browse the repository at this point in the history

  73. review: rename arg' and move in the right branch

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    e263430 View commit details
    Browse the repository at this point in the history

  74. review: less adhoc printing for functor param errors

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7d1d25d View commit details
    Browse the repository at this point in the history

  75. review: small tweaks

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    605b72f View commit details
    Browse the repository at this point in the history

  76. review: no more sub messages

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c7aeda4 View commit details
    Browse the repository at this point in the history

  77. review: fix previous commit

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b951b72 View commit details
    Browse the repository at this point in the history

  78. review: includemod_errorprinter small simplifications

    @Octachron
    Octachron committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1d360f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. review: the great reorganization

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d8e092d View commit details
    Browse the repository at this point in the history

  2. review: specialized error message for single argument and change

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    3d1d908 View commit details
    Browse the repository at this point in the history

  3. includemod_errorprinter: remove unused field

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    c16f158 View commit details
    Browse the repository at this point in the history

  4. includemod_errorprinter: simplify functor arg description

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    39a4300 View commit details
    Browse the repository at this point in the history

  5. review: remove polymorphic variant

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    217f93f View commit details
    Browse the repository at this point in the history

  6. includemod_errorprinter: simplify Functor_suberror

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2649f01 View commit details
    Browse the repository at this point in the history

  7. review: Short_name ⇒ With_shorthand

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    5a35a74 View commit details
    Browse the repository at this point in the history

  8. includemod_errorprinter: more explicit names

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    29f17d4 View commit details
    Browse the repository at this point in the history

  9. probable fix: remove Btype.snapshot

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4fad788 View commit details
    Browse the repository at this point in the history

  10. includemod_errorprinter: duclicate Inclusion.insert

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    efc9146 View commit details
    Browse the repository at this point in the history

  11. includemod_errorprinter: better name

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    98a2375 View commit details
    Browse the repository at this point in the history

  12. please depend CI

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    25eb73c View commit details
    Browse the repository at this point in the history

  13. review: use find_modtype_expansion

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    8e512f1 View commit details
    Browse the repository at this point in the history

  14. review: use id$n for ident names and not p$n

    @Octachron
    Octachron committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2074959 View commit details
    Browse the repository at this point in the history