Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pattern-matching compiler: refactor the toplevel handling of partiality #9651

Merged
merged 3 commits into from
Nov 21, 2020
Merged

pattern-matching compiler: refactor the toplevel handling of partiality #9651

merged 3 commits into from
Nov 21, 2020
+47 −85

Commits on Nov 21, 2020

  1. matching: [minor] inline the single-use split_and_precompile 

    This comes from a suggestion by Florian Angeletti in
  ocaml#9447 (comment)
    @gasche
    gasche committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    def877e View commit details
    Browse the repository at this point in the history

  2. matching: factorize the code handling toplevel matching failures

    @gasche
    gasche committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    7d777f2 View commit details
    Browse the repository at this point in the history

  3. matching: use toplevel_handler in for_tupled_function 

    This appears to change the function behavior with respect to the
Unused exception, but we believe that the change is correct. It makes
the code more consistent with other toplevel compilation functions.
    @gasche
    gasche committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    67ba8c3 View commit details
    Browse the repository at this point in the history