-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide for linking the native toplevel now exposed as 'ocamltoplevel.cmxa' #10
Conversation
An alternative which may be better is to provide it as an alternate package: modified site-lib-src/compiler-libs/META.in
@@ -30,10 +30,16 @@
`)'
`package "toplevel" ('
-` requires = "compiler-libs.bytecomp compiler-libs.optcomp dynlink"'
+` requires = "compiler-libs.bytecomp"'
` version = "[distributed with Ocaml]"'
` description = "Toplevel interactions"'
` archive(byte) = "ocamltoplevel.cma"'
+`)'
+
+`package "native-toplevel" ('
+` requires = "compiler-libs.bytecomp compiler-libs.optcomp dynlink"'
+` version = "[distributed with Ocaml]"'
+` description = "Toplevel interactions"'
` archive(native) = "ocamltoplevel.cmxa"'
`)' So consumers of the current toplevel won't see a change of behaviour, and it's easy to switch to try a native build. |
@AltGr unfortunately there is no |
I'm not sure how versioning works in ocamlfind, but does this change in the installed META file happen for all compiler versions? |
@emillon if the META files have to be different by compiler version, the only way is to check the version in the configure script and generate the META file from that. |
Updated with the separate version, where I added an |
As per ocaml/ocamlfind#10 Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com>
As per ocaml/ocamlfind#10 Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com>
As per ocaml/ocamlfind#10 Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com>
@gerdstolpmann does the current state of the PR looks good to you? The corresponding changes to OCaml have now been merged. |
As per ocaml/ocamlfind#10 Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
As per ocaml/ocamlfind#10 Signed-off-by: Louis Gesbert <louis.gesbert@ocamlpro.com>
See ocaml/ocaml#10124
This is clearly not optimal, since it will force linking to the native
backend and dynlink even for bytecode mode ; is there a way to specify
requires(byte)
andrequires(native)
?