Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] rfc1951 and decompress (1.4.3) #21155

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

dinosaure
Copy link
Contributor

Implementation of RFC1951 in OCaml

CHANGES:

CHANGES:

- Replace deprecated function of `fmt` (@dinosaure, mirage/decompress#135)
- Remove `bigarray-compat`, `stdlib-shims` and support only
  OCaml >= 4.08.0 (@hannesm, mirage/decompress#138)
- Update to `cmdliner.1.1.0` (@hannesm, mirage/decompress#138)
@dinosaure
Copy link
Contributor Author

- @@ -24,6 +24,65 @@ Test reverse bindings
-    > }
-    > EOF
-    $ cc -o a.out main.c -I$(ocamlopt -where) -L../../bindings/stubs -I../../bindings/stubs -ldecompress -lm -ldl
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_re_register':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:120: undefined reference to `pthread_getspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_backtrack_stack':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:106: undefined reference to `pthread_getspecific'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:111: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_re_register':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:124: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_backtrack_stack':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:106: undefined reference to `pthread_getspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_str_domain_stop_hook':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:147: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_re_register':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:120: undefined reference to `pthread_getspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_str_domain_stop_hook':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:154: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_re_register':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:124: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `get_backtrack_stack':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:111: undefined reference to `pthread_setspecific'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_str_initialize':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:168: undefined reference to `pthread_key_create'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/otherlibs/str/strstubs.c:169: undefined reference to `pthread_key_create'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_execute_signal_exn':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/signals.c:191: undefined reference to `pthread_sigmask'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/signals.c:204: undefined reference to `pthread_sigmask'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_process_pending_signals_exn':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/signals.c:80: undefined reference to `pthread_sigmask'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_plat_try_lock':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/caml/platform.h:131: undefined reference to `pthread_mutex_trylock'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_plat_mutex_init':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/platform.c:17: undefined reference to `pthread_mutexattr_init'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/platform.c:19: undefined reference to `pthread_mutexattr_settype'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/platform.c:24: undefined reference to `pthread_mutexattr_destroy'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/platform.c:24: undefined reference to `pthread_mutexattr_destroy'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_plat_cond_init_aux':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/platform.c:61: undefined reference to `pthread_condattr_setclock'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `install_backup_thread':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/domain.c:658: undefined reference to `pthread_create'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/domain.c:662: undefined reference to `pthread_detach'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_plat_try_lock':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/caml/platform.h:131: undefined reference to `pthread_mutex_trylock'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_domain_spawn':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/domain.c:749: undefined reference to `pthread_create'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/domain.c:771: undefined reference to `pthread_detach'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/domain.c:775: undefined reference to `pthread_join'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `caml_plat_try_lock':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/caml/platform.h:131: undefined reference to `pthread_mutex_trylock'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `sync_mutex_create':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/sync.c:25: undefined reference to `pthread_mutexattr_init'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/sync.c:39: undefined reference to `pthread_mutexattr_destroy'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/sync.c:27: undefined reference to `pthread_mutexattr_settype'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/sync.c:39: undefined reference to `pthread_mutexattr_destroy'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/sync.c:33: undefined reference to `pthread_mutexattr_destroy'
- +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): in function `sync_mutex_trylock':
- +  /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/caml/sync.h:31: undefined reference to `pthread_mutex_trylock'
- +  /usr/bin/ld: /home/opam/.opam/4.12/.opam-switch/build/ocaml-variants.4.12.0+domains/runtime/caml/sync.h:31: undefined reference to `pthread_mutex_trylock'
- +  collect2: error: ld returned 1 exit status
- +  [1]
-    $ ./a.out
- -  Hello World!
- +  ./a.out: not found
- +  [127]

The error about domain is well know, see: ocaml-multicore/ocaml-multicore#602

#    $ cc -o a.out main.c -I$(ocamlopt -where) -L../../bindings/stubs -I../../bindings/stubs -ldecompress -lm -ldl
# +  /usr/bin/ld: ../../bindings/stubs/libdecompress.a(decompress.exe.o): warning: relocation in read-only section `.text'
# +  /usr/bin/ld: warning: creating DT_TEXTREL in a PIE
#    $ ./a.out
#    Hello World!

The error about this test is probably related to: ocaml/ocaml#10835 But the rest of the test confirm that everything works. I should however, silently compiles the program.

@dinosaure
Copy link
Contributor Author

Consider #21163 for errors about carton.

@dinosaure dinosaure merged commit edb978a into ocaml:master Apr 11, 2022
@dinosaure dinosaure deleted the release-rfc1951-v1.4.3 branch April 11, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant