fix: remove yarn.lock if yarn wasnt selected (#1365)

oclif · Apr 9, 2024 · a8d3bfa · a8d3bfa
1 parent 9319f53
commit a8d3bfa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/commands/generate.ts b/src/commands/generate.ts
@@ -255,6 +255,10 @@ export default class Generate extends GeneratorCommand<typeof Generate> {
 
     await writeFile(join(location, '.gitignore'), updated)
 
+    if (packageManager !== 'yarn') {
+      await rm(join(location, 'yarn.lock'))
+    }
+
     await exec(`${packageManager} install`, {cwd: location, silent: false})
     await exec(`${join(location, 'node_modules', '.bin', 'oclif')} readme`, {
       cwd: location,

diff --git a/test/integration/cli.test.ts b/test/integration/cli.test.ts
@@ -55,6 +55,20 @@ describe(`Generated CLI Integration Tests ${MODULE_TYPE} + ${PACKAGE_MANAGER} +
     const result = await exec(`${cliBinRun} hello world`, {cwd: cliDir})
     expect(result.code).to.equal(0)
     expect(result.stdout).to.equal('hello world! (./src/commands/hello/world.ts)\n')
+
+    if (PACKAGE_MANAGER === 'yarn') {
+      expect(existsSync(join(cliDir, 'yarn.lock'))).to.be.true
+    }
+
+    if (PACKAGE_MANAGER === 'npm') {
+      expect(existsSync(join(cliDir, 'package-lock.json'))).to.be.true
+      expect(existsSync(join(cliDir, 'yarn.lock'))).to.be.false
+    }
+
+    if (PACKAGE_MANAGER === 'pnpm') {
+      expect(existsSync(join(cliDir, 'pnpm-lock.yaml'))).to.be.true
+      expect(existsSync(join(cliDir, 'yarn.lock'))).to.be.false
+    }
   })
 
   it('should generate a new command', async () => {